cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: make portal-client dependency optional

Open hanna-skryl opened this issue 1 year ago โ€ข 1 comments

Closes #474

  • Make @code-pushup/portal-client an optional dependency in the @code-pushup/core package.
  • Update the core package to use dynamic imports for @code-pushup/portal-client.
  • Add a utility function to handle the loading of the portal client.
  • Update the installation instructions to guide users on omitting optional dependencies, including details for npm, pnpm, and yarn setups.

hanna-skryl avatar Oct 11 '24 22:10 hanna-skryl

Code PushUp

๐Ÿคจ Code PushUp report has both improvements and regressions โ€“ compared target commit 01f02b65055666dc59e90d03dcaabe9ab16044ea with source commit c420a682302c5eec6e24237af6965c60795ff912.

๐Ÿ•ต๏ธ See full comparison in Code PushUp portal ๐Ÿ”

๐Ÿท๏ธ Categories

๐Ÿท๏ธ Category โญ Previous score โญ Current score ๐Ÿ”„ Score change
Performance ๐ŸŸก 52 ๐Ÿ”ด 43 โ†“ โˆ’8.9
Code coverage ๐ŸŸข 90 ๐ŸŸข 90 โ†“ โˆ’0.1
Custom checks ๐ŸŸก 67 ๐ŸŸก 67 โ€“
Security ๐ŸŸก 82 ๐ŸŸก 82 โ€“
Updates ๐ŸŸก 77 ๐ŸŸก 77 โ€“
Accessibility ๐ŸŸข 91 ๐ŸŸข 91 โ€“
Best Practices ๐ŸŸข 100 ๐ŸŸข 100 โ€“
SEO ๐ŸŸก 61 ๐ŸŸก 61 โ€“
Bug prevention ๐ŸŸข 100 ๐ŸŸข 100 โ€“
Code style ๐ŸŸข 99 ๐ŸŸข 99 โ€“
๐Ÿ‘Ž 2 groups regressed, ๐Ÿ‘ 2 audits improved, ๐Ÿ‘Ž 6 audits regressed, 11 audits changed without impacting score

๐Ÿ—ƒ๏ธ Groups

๐Ÿ”Œ Plugin ๐Ÿ—ƒ๏ธ Group โญ Previous score โญ Current score ๐Ÿ”„ Score change
Lighthouse Performance ๐ŸŸก 52 ๐Ÿ”ด 43 โ†“ โˆ’8.9
Code coverage Code coverage metrics ๐ŸŸข 90 ๐ŸŸข 90 โ†“ โˆ’0.1

18 other groups are unchanged.

๐Ÿ›ก๏ธ Audits

๐Ÿ”Œ Plugin ๐Ÿ›ก๏ธ Audit ๐Ÿ“ Previous value ๐Ÿ“ Current value ๐Ÿ”„ Value change
Lighthouse Largest Contentful Paint ๐ŸŸจ 3.2ย s ๐ŸŸฅ 4.2ย s โ†‘ +32.2โ€‰%
Lighthouse First Contentful Paint ๐ŸŸฅ 3.2ย s ๐ŸŸฅ 3.6ย s โ†‘ +15.5โ€‰%
Lighthouse First Meaningful Paint ๐ŸŸจ 3.2ย s ๐ŸŸจ 3.6ย s โ†‘ +15.5โ€‰%
Lighthouse Speed Index ๐ŸŸฅ 6.4ย s ๐ŸŸฅ 6.6ย s โ†‘ +2.2โ€‰%
Lighthouse Time to Interactive ๐ŸŸฅ 19.6ย s ๐ŸŸฅ 17.8ย s โ†“ โˆ’8.8โ€‰%
Code coverage Branch coverage ๐ŸŸจ 85.4 % ๐ŸŸจ 85.3 % โ†“ โˆ’0.1โ€‰%
Code coverage Line coverage ๐ŸŸฉ 91.5 % ๐ŸŸฉ 91.5 % โ†“ โˆ’0.1โ€‰%
Code coverage Function coverage ๐ŸŸฉ 92.4 % ๐ŸŸฉ 92.4 % โ†‘ +0.1โ€‰%
Lighthouse Avoids enormous network payloads ๐ŸŸฉ Total size was 1,823ย KiB ๐ŸŸฉ Total size was 1,818ย KiB โ†“ โˆ’0.2โ€‰%
Lighthouse Minimizes main-thread work ๐ŸŸฅ 24.3ย s ๐ŸŸฅ 22.4ย s โ†“ โˆ’8โ€‰%
Lighthouse Total Blocking Time ๐ŸŸฅ 9,650ย ms ๐ŸŸฅ 7,920ย ms โ†“ โˆ’18โ€‰%
Lighthouse Metrics ๐ŸŸฉ 100% ๐ŸŸฉ 100% โ†“ โˆ’8.8โ€‰%
Lighthouse Max Potential First Input Delay ๐ŸŸฅ 4,900ย ms ๐ŸŸฅ 3,220ย ms โ†“ โˆ’34.3โ€‰%
Lighthouse JavaScript execution time ๐ŸŸฅ 11.8ย s ๐ŸŸฅ 11.0ย s โ†“ โˆ’6.1โ€‰%
Lighthouse Eliminate render-blocking resources ๐ŸŸฅ Potential savings of 1,270ย ms ๐ŸŸฅ Potential savings of 1,490ย ms โ†‘ +16.6โ€‰%
Lighthouse Uses efficient cache policy on static assets ๐ŸŸจ 27 resources found ๐ŸŸจ 27 resources found โ†‘ +0.1โ€‰%
Lighthouse Server Backend Latencies ๐ŸŸฉ 150ย ms ๐ŸŸฉ 220ย ms โ†‘ +47.6โ€‰%
Lighthouse Network Round Trip Times ๐ŸŸฉ 20ย ms ๐ŸŸฉ 60ย ms โ†‘ +173.3โ€‰%
Lighthouse Initial server response time was short ๐ŸŸฉ Root document took 410ย ms ๐ŸŸฉ Root document took 380ย ms โ†“ โˆ’5.9โ€‰%

494 other audits are unchanged.

github-actions[bot] avatar Oct 11 '24 23:10 github-actions[bot]