bricks icon indicating copy to clipboard operation
bricks copied to clipboard

Sentence complete classifier

Open LeonardPuettmannKern opened this issue 2 years ago • 0 comments

refinery

  • [ ] Tested by creator on refinery
  • [ ] Tested by reviewer on refinery
  • [ ] Ensured that output of brick conforms with refinery structure (to be checked by reviewer)

API

  • [ ] Tested by creator on localhost:8000/docs
  • [ ] Tested by reviewer on localhost:8000/docs

common code

  • [x] Common code tested in notebook/ script by creator
  • [ ] Common code tested in notebook/ script by reviewer
  • [ ] Common code contains docstrings and type hints

additional points:

  • [ ] Docstring and README is existing
  • [ ] Import statements (in __init__.py)
  • [ ] (If necessary) Added dependency to requirements.txt
  • [ ] (If necessary) Added dependency to issue for refinery env here
  • [ ] Published brick to Strapi CMS (locally)

@FelixKirschKern Not sure at all about the logic behind this brick, would love to get your feedback. Classifying whether or not a sentence is complete is not easy, but I think it's alright to check if a sentence already has some features we would expect in a usual sentence (Uppercase character in the beginning, end with a punctuation and contains nouns and a verb). This will of course miss some sentences. I also expect that the input will rarely just be one sentence, but multiple sentences in a text that might just be cut off at the end due to chunking. There might be better ways for for the aggregation part, too.

LeonardPuettmannKern avatar Oct 19 '23 17:10 LeonardPuettmannKern