code-corps-api icon indicating copy to clipboard operation
code-corps-api copied to clipboard

Fix validation errors for timestamps in GitHub syncing to not error but ignore

Open joshsmith opened this issue 8 years ago • 3 comments

Problem

Right now if there are validation errors due to timestamps being off in GitHub syncing, it appears we're seeing validating_tasks or validating_comments errors. What we should do instead is actually ensure that if the timestamps are off, that we instead say the event payload was ignored due to timestamp differences.

joshsmith avatar Oct 24 '17 21:10 joshsmith

This would be a matter of interpreting a transaction outcome as an :ok.

~ 2 hours to make the changes and update tests. Bulk of the time will likely be in tests.

begedin avatar Oct 30 '17 21:10 begedin

Related to issue raised in #1148, it looks like we may need to consider this even more fully here.

If something is syncing from GitHub but the timestamp is outdated on GitHub's side, it should not just be ignored; it likely also needs to kick off a resync to GitHub for that Task or Comment.

joshsmith avatar Nov 05 '17 21:11 joshsmith

The passing test in #1198 can serve as the basis for writing a failing test for this.

joshsmith avatar Nov 16 '17 05:11 joshsmith