youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Refactor: rename js&css directory

Open 4yman-0 opened this issue 1 year ago • 10 comments

This PR: - Divides the folder js&css into 2 directories: js and css #2340. - Renames stuff to resources.

4yman-0 avatar Jun 18 '24 14:06 4yman-0

hi! and thanks @4yman-el js & css are friends, stuff is short

ImprovedTube avatar Jun 18 '24 16:06 ImprovedTube

stuff is short

OK, i'll rename it again

4yman-0 avatar Jun 18 '24 20:06 4yman-0

How about res?

4yman-0 avatar Jun 18 '24 20:06 4yman-0

One one hand modern file systems can handle & no problem, on the other hand separating CSS to its own directory does feel much cleaner and nicer.

raszpl avatar Jun 20 '24 08:06 raszpl

TYSM again! 4yman-el i'm story to be 'stubborn' this time to delay this in favor of our habit clicking through exactly this structure for right now and once we change it then we might change more. (Draft is not what i meant but #later or #optional-inspiration)

(and the price renaming costs, is adding an extra page to to edit histories on github to each of the files)

before doing much more of this i would like to prepare command lines still to rewrite the commit history most conveniently. (or hope to find the perfect ready made tool for that)

on the other hand separating CSS to its own directory does feel much cleaner and nicer.

yet hardly separated on the client-side. @raszpl / Some of the css&js pairs /neighbors might be edited at once. i'd consider to mix in html, json, sql(-lite), csv at need & call the folder (browser-)code.

And, not said yet: Since this project sometimes is about entertainment (youtube) and young users, it would makes sense that the naming fit a bit of a broader audience (rare/new/hobby developers) who might also potentially fix something little sometimes.

ImprovedTube avatar Jun 20 '24 17:06 ImprovedTube

Makes sense for today? Wish i could already /first make productive contributors reply to bigger concepts /visions like:

  • https://github.com/code-charity/Bulk-Contributor
    • https://github.com/code-charity/crowd-fixes
      • and in future a lot of our css & js could be converted from & to the rule format/s of ublockOrigin & Adblock. To eventually be versatile and Bulk managed. To automatically contribute to a few projects all at once and have this project inherit work form others too.

ImprovedTube avatar Jun 20 '24 17:06 ImprovedTube

off-topic?

(now #2415)

4yman-0 avatar Jun 24 '24 07:06 4yman-0

@raszpl @ImprovedTube We probably have to move this to a new issue or discussion.

4yman-0 avatar Jun 25 '24 19:06 4yman-0

@4yman-el you chose

ImprovedTube avatar Jun 25 '24 21:06 ImprovedTube

inviting you to the organisation so that you can set labels in future (or assign. or close duplicates)

ImprovedTube avatar Jun 25 '24 22:06 ImprovedTube

thanks for 8cab0ca!

4yman-0 avatar Jul 04 '24 09:07 4yman-0

@ImprovedTube Please review now.

4yman-0 avatar Jul 17 '24 15:07 4yman-0

Each PR has its own purpose, please merge or push to master instead of this fork/branch. I was confused by the commits named typo, - etc. edit: small typo

4yman-0 avatar Jul 18 '24 11:07 4yman-0