cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

ui: sql activity pages depend on node info

Open matthewtodd opened this issue 3 years ago • 2 comments

Fixes #85249.

Previously, the statements, transactions, and transaction details pages had an implicit dependency on the state.adminUI.nodes list in the redux store, and without that list, the Regions/Nodes columns and filters would be incorrectly hidden for multiregion clusters, unless the user happened to have already browsed through a page (such as statement details) that loaded the list.

(This bug was affecting dedicated cloud clusters only. Self-hosted clusters were working properly because their global mechanism to sync alert data happened to refresh the node list.)

This change makes the dependency explicit and refreshes the list of nodes on entering those three pages.

Before After
Screen Shot 2022-09-22 at 10 42 33 AM Screen Shot 2022-09-22 at 10 41 12 AM
Screen Shot 2022-09-22 at 10 42 42 AM Screen Shot 2022-09-22 at 10 41 22 AM
Screen Shot 2022-09-22 at 10 43 00 AM Screen Shot 2022-09-22 at 10 41 38 AM

Release note (bug fix): The statements, transactions, and transaction details pages in the admin console now properly show the Regions/Nodes columns and filters for multiregion clusters.

matthewtodd avatar Sep 22 '22 15:09 matthewtodd

This change is Reviewable

cockroach-teamcity avatar Sep 22 '22 15:09 cockroach-teamcity

(I'm having trouble getting the build to kick off, have force-pushed a couple of times to see if that'll do it. 🤞🏻)

matthewtodd avatar Sep 22 '22 18:09 matthewtodd

bors r+

matthewtodd avatar Sep 23 '22 13:09 matthewtodd

Build succeeded:

craig[bot] avatar Sep 23 '22 15:09 craig[bot]

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4fe7d93a5fb130972262c6234e9cac8750d0b8df to blathers/backport-release-22.1-88461: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

blathers-crl[bot] avatar Sep 23 '22 15:09 blathers-crl[bot]

@matthewtodd looks like the backport to 22.1 didn't happen, can you create one? Thanks!

maryliag avatar Sep 27 '22 14:09 maryliag