cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

rangeDesc: provide an RDI iterator integrated with elastic admission control

Open msbutler opened this issue 7 months ago • 2 comments

We observed in #147759 that backup's use of an RDI can degrade the foreground workload. We suspect that integrating elastic admission control into the RDI could prevent this.

Additional slack thread here.

Jira issue: CRDB-51626

msbutler avatar Jun 17 '25 16:06 msbutler

Hi @msbutler, please add branch-* labels to identify which branch(es) this C-bug affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Jun 17 '25 16:06 blathers-crl[bot]

@msbutler Is this work that is in backup area of in KV? And what is the priority of this ticket?

dshjoshi avatar Jun 18 '25 15:06 dshjoshi

@msbutler @arulajmani Will this be part of KV work or DR work? - Thanks!

dshjoshi avatar Jun 20 '25 15:06 dshjoshi

@msbutler any reason this was marked as a P-1? IIUC, this issue is very similar to other issues where foreground latency is impacted because of O(nodes/stores/ranges) work, all of which are marked as P-3s (e.g.https://github.com/cockroachdb/cockroach/issues/148211)

@dshjoshi this falls into KV.

arulajmani avatar Jul 07 '25 21:07 arulajmani

@arulajmani no strong reason this was marked as a P1. Feel free to reprioritize.

msbutler avatar Jul 08 '25 17:07 msbutler

Action item: grab a cpu profile at the beginning of a backup

msbutler avatar Oct 08 '25 19:10 msbutler

@arulajmani @msbutler Given that , this is marked as P-3 ; can we remove "300-node-qualification-blocker" label from it?

dshjoshi avatar Oct 09 '25 13:10 dshjoshi

Confirmation from Rima that this is not "300-node-qualification-blocker"

dshjoshi avatar Oct 10 '25 21:10 dshjoshi