cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

roachtest: tolerate errors on gracefuldraining test

Open andrewbaptist opened this issue 1 year ago • 2 comments

Previously the test could return an ambiguous error if there was a combination of a RangeMismatchError and an AmbiguousError. This would request would be successful if the range info was updated and the request retried, but we don't do that today.

Informs: #129427 Epic: none

Release note: None

andrewbaptist avatar Aug 28 '24 19:08 andrewbaptist

This change is Reviewable

cockroach-teamcity avatar Aug 28 '24 19:08 cockroach-teamcity

I chatted with @arulajmani. The "correct" fix to DistSender is too complex. The reason the gossip change makes this more likely is due to additional rebalancing due to stale information from less frequent gossiping. It exposes a problem where we incorrectly return an ambiguous error, but this is rare enough that it is OK for now and the tracking issue can be used to determine if we eventually fix this.

andrewbaptist avatar Aug 28 '24 19:08 andrewbaptist

TFTR

bors r=kvoli

andrewbaptist avatar Aug 29 '24 13:08 andrewbaptist

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from cfefe71cbde605be2208a65c74b993086155988c to blathers/backport-release-24.1-129829: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.


error creating merge commit from cfefe71cbde605be2208a65c74b993086155988c to blathers/backport-release-24.2-129829: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Aug 29 '24 13:08 blathers-crl[bot]