cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

[wip] prototyping for rangefeed scalability work

Open wenyihu6 opened this issue 1 year ago • 3 comments

Just prototyping - This patch reduces registration goroutines and removes r.buf at rangefeed level.

TODO:

  • rationalize memory accounting
  • tests
  • is it okay to send same registration error twice

Shutdown logic: https://docs.google.com/document/d/1rQzVYnI4XuWloenEYa_9cvQ5aVYPlhR2cb8IAQKo6_M/edit?usp=sharing

wenyihu6 avatar May 28 '24 16:05 wenyihu6

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 28 '24 16:05 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar May 28 '24 16:05 cockroach-teamcity

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Jun 01 '24 13:06 blathers-crl[bot]

Was just for prototyping.

wenyihu6 avatar Oct 24 '24 05:10 wenyihu6