cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

dev: move local loopback cache line from `~/.bazelrc` to `.bazelrc.user`

Open rickystewart opened this issue 1 year ago • 2 comments

There hasn't been any particular reason we put it in ~/.bazelrc before, except that it "doesn't hurt" to have it in the home directory, where you get to take advantage of it in any Bazel workspace you happen to be using. However, as we want to add opt-in support for remote execution to dev (which is incompatible with using the local loopback cache), it now makes more sense to opt in to this on a workspace-by-workspace basis. That means it properly belongs in .bazelrc.user instead.

Here we update the relevant dev doctor check to look in .bazelrc.user instead, and update the auto-fix to delete the line from ~/.bazelrc if it's there.

Part of: CRDB-34610 Epic: CRDB-34137 Release note: None

rickystewart avatar May 24 '24 20:05 rickystewart

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 24 '24 20:05 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar May 24 '24 20:05 cockroach-teamcity

bors r=rail

rickystewart avatar Jun 03 '24 16:06 rickystewart