cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

log: change fingerprint_id type to string

Open kyle-a-wong opened this issue 1 year ago • 2 comments

Previously, transaction_fingerprint_id and statement_fingerprint_id were typed as uint64. Somewhere downstream, these uint64 fields were truncated into int64 max ints. As a result, telemetry logs had the same fingerprint id for different sql statements.

To fix, the field name was re-typed as a string to ensure no truncation / type conversion happens.

Epic: none Fixes: #123665 Release note (bug fix): Fixed a bug where telemetry logs were had the same statement fingerprint id for different sql statements.

kyle-a-wong avatar May 23 '24 20:05 kyle-a-wong

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 23 '24 20:05 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar May 23 '24 20:05 cockroach-teamcity

bors r+

kyle-a-wong avatar May 30 '24 21:05 kyle-a-wong

Merge conflict.

craig[bot] avatar May 30 '24 21:05 craig[bot]

bors r+

kyle-a-wong avatar May 31 '24 14:05 kyle-a-wong