cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

ui: upgrade `antd` package to v5 in cluster-ui

Open koorosh opened this issue 1 year ago • 7 comments

This change upgrades antd package (in cluster-ui) up to 5.x version to match the version in CC Console and make it easier to extract components. It is preferable to review those changes per commit:

  • first commit introduces changes in build files (package.json, webpack, etc)
  • next commit contains changes produced by command: pnpm --package=@ant-design/codemod-v5 dlx antd5-codemod src
  • final commit resolves braking changes after antd version upgrade.

Note, those changes doesn't fix broken styles of components and it affects how some components look in Db Console.

Resolves: https://cockroachlabs.atlassian.net/browse/CC-28016

  • [ ] mirror NPM dependencies with dev ui mirror-deps

koorosh avatar May 10 '24 20:05 koorosh

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 10 '24 20:05 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar May 10 '24 20:05 cockroach-teamcity

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 14 '24 12:05 blathers-crl[bot]

UX concerns:

  • SQL activity page, time range selector and search placeholder text
  • Databases page, search input active state
  • Metrics page time selector dropdown alignment in the input + back/forward buttons

innabs avatar May 14 '24 17:05 innabs

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 21 '24 11:05 blathers-crl[bot]

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 21 '24 14:05 blathers-crl[bot]

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 24 '24 09:05 blathers-crl[bot]

I checked this out and ran mirror-deps 👍

laurenbarker avatar May 31 '24 15:05 laurenbarker

Closing this PR in favor of https://github.com/cockroachdb/cockroach/pull/124100 as changes in cluster-ui consequently break code in Db Console (incompatible interfaces of Antd components)

koorosh avatar Jun 10 '24 10:06 koorosh