cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

opt/execbuilder: fix EXPORT when input expression has hidden columns

Open mgartner opened this issue 1 year ago • 2 comments

opt/execbuilder: fix EXPORT when input expression has hidden columns

Fixes #115290

Release note (bug fix): A bug has been fixed that caused internal errors when executing EXPORT statement.

opt/execbuilder: remove getNodeColumnOrdinalSet

This simple function was only used in one place, so it has been inlined and removed.

Release note: None

mgartner avatar Feb 22 '24 20:02 mgartner

This change is Reviewable

cockroach-teamcity avatar Feb 22 '24 20:02 cockroach-teamcity

Probably worth backporting this too, right?

rytaft avatar Feb 22 '24 21:02 rytaft

Probably worth backporting this too, right?

Yes - added the labels.

mgartner avatar Feb 27 '24 01:02 mgartner

TFTRs!

bors r+

mgartner avatar Feb 27 '24 14:02 mgartner

Build succeeded:

craig[bot] avatar Feb 27 '24 15:02 craig[bot]

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 592272ca2aa909fc5dd3aed29eb3fff30c567120 to blathers/backport-release-23.1-119538: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from 592272ca2aa909fc5dd3aed29eb3fff30c567120 to blathers/backport-release-23.2-119538: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Feb 27 '24 15:02 blathers-crl[bot]