cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

release-23.2: catalog/lease: optimize lease count query

Open fqazi opened this issue 1 year ago • 3 comments

Previously, the query to count leases would end up scanning the entire system.leases table because of the addition of crdb_region as the first column on 23.1. This meant that scans not specifying a region would always be forced to scan the entire table. To address this, this patch will update the count query to specify the default region when working on single region system databases.

Fixes: #119456

Release note (bug fix): Schema changes with a large number of descriptors could end up doing full table scans on system.leases.

Release justification: a low risk fix that optimizes the leasing query for non-multi-region clusters, which was causing a regression for customers.

fqazi avatar Feb 21 '24 16:02 fqazi

Thanks for opening a backport.

Please check the backport criteria before merging:

  • [ ] Backports should only be created for serious issues or test-only changes.
  • [ ] Backports should not break backwards-compatibility.
  • [ ] Backports should change as little code as possible.
  • [ ] Backports should not change on-disk formats or node communication protocols.
  • [ ] Backports should not add new functionality (except as defined here).
  • [ ] Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • [ ] All backports must be reviewed by the owning areas TL and one additional TL. For more information as to how that review should be conducted, please consult the backport policy.
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

blathers-crl[bot] avatar Feb 21 '24 16:02 blathers-crl[bot]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Feb 21 '24 16:02 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Feb 21 '24 16:02 cockroach-teamcity

We should also post this in the backports channel.

rimadeodhar avatar Feb 26 '24 19:02 rimadeodhar

@mgartner @rimadeodhar TFTR!

fqazi avatar Feb 28 '24 03:02 fqazi