cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

workload: handle ambiguous errors

Open renatolabs opened this issue 2 years ago • 3 comments

Clients are expected to handle ambiguous errors; for instance, see our own documentation:

Despite that, our very own workload does not handle these errors, leading to occasional roachtest failures that should not have happened.

We want workload to be able to handle these errors whenever possible (retrying when safe to do so). It might not be possible to completely eliminate these errors from bubbling up to the caller every time; each workload should be updated independently.

Jira issue: CRDB-30113

renatolabs avatar Jul 25 '23 20:07 renatolabs

cc @cockroachdb/test-eng

blathers-crl[bot] avatar Jul 25 '23 20:07 blathers-crl[bot]

Since this has come up in the context of performance benchmarks, we should be careful not to retry excessively. In some sense, a benchmark becomes tainted since retries could yield to performance degradation.

srosenberg avatar Jul 26 '23 17:07 srosenberg

At least one type of "incorrect ambiguous" error is described here: https://github.com/cockroachdb/cockroach/issues/129427. The short term fix for that issue is to tolerate errors, but this isn't a great general fix.

andrewbaptist avatar Aug 28 '24 19:08 andrewbaptist