external_import icon indicating copy to clipboard operation
external_import copied to clipboard

Interface "TYPO3\CMS\Reactions\Reaction\ReactionInterface" not found

Open linawolf opened this issue 2 years ago • 5 comments

I just installed cobweb/external_import (7.1.1) on TYPO3 v 12.4.6 and after Installing I get the error

Interface "TYPO3\CMS\Reactions\Reaction\ReactionInterface" not found

in /var/www/html/vendor/cobweb/external_import/Classes/Reaction/ImportReaction.php line 34

The class tries to implement this interface, however the exstensions composer.json does not require typo3/cms-reactions

linawolf avatar Oct 09 '23 09:10 linawolf

That's a tough one. The extension can't require typo3/cms-reactions because it's meant to remain compatible with TYPO3 11 for now. What I can do for now is add a note in the Installation chapter of the documentation.

Later, when compatibility with TYPO3 11 is dropped, the requirement can be added.

fsuter avatar Oct 17 '23 07:10 fsuter

Sorry for opening a duplicate :/ My initial problem was the wrongly created table sys_reaction from an update deployment with database:updateschema

Incorrect table definition; there can be only one auto column and it must be defined as a key
Key column 'uid' doesn't exist in table

I removed the extension since we won't need it otherwise and i ended up with the other error --> then had to remove the table manually and recreate it with the update wizard.

Maybe the external_import_configuration field can be added through the AlterTableDefinitionStatementsEvent event if the reactions extension is installed + TCA would also need a check for ExtensionManagementUtility::isloaded('reactions') and we should be good to go? I disabled the sql, wrapped the TCA with the condition and removed the reactions extension -> no error.

Adding it to suggests should then be enough vor > v12?

akiessling avatar Apr 12 '24 22:04 akiessling

I agree that the current state can create quite a mess. Thanks for suggesting the various elements that can improve the situation. I'll take a look.

fsuter avatar Apr 13 '24 09:04 fsuter

Would you like me to come up with a pull request?

akiessling avatar Apr 13 '24 09:04 akiessling

Pull requests are always welcome and definitely improve the chances of the bug being fixed ;-) Thanks for the proposal.

fsuter avatar Apr 13 '24 15:04 fsuter

Oh my, i had it on my todo list but could not find any spare time :/ thanks for taking care!

akiessling avatar May 23 '24 18:05 akiessling