community icon indicating copy to clipboard operation
community copied to clipboard
verified publisher icon coala

Corrected the number of badges and levels in gamification.

Open alirizwi opened this issue 7 years ago • 6 comments

test_management_commands.py: Correct the number of badges and levels in gamification

This corrects the number of badges and levels in the comments as the number of badges and levels written in the comments are different from the number used in the code.

Fixes: https://github.com/coala/community/issues/195

alirizwi avatar Sep 25 '18 04:09 alirizwi

@shikharvaish28 Please review the PR. Thanks

alirizwi avatar Sep 25 '18 04:09 alirizwi

Hi @alirizwi , Read http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html and change your commit message accordingly.

ishucr7 avatar Sep 25 '18 05:09 ishucr7

@li-boxuan @ishucr7 Changed the commit message. Please review. Thanks!

alirizwi avatar Sep 26 '18 09:09 alirizwi

@shikharvaish28 @ishucr7 Updated. Please review.

alirizwi avatar Sep 28 '18 10:09 alirizwi

Hi @alirizwi , Just a small nit and then it's good to go. Change comments are different with to comments are different from Thanks.

ishucr7 avatar Sep 28 '18 10:09 ishucr7

Hi, I think you need to limit your heading to less than 50 characters and squash your commits. You may refer to http://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits

Gromy1211 avatar Feb 25 '19 12:02 Gromy1211