coala-html icon indicating copy to clipboard operation
coala-html copied to clipboard

Search in Results

Open AbdealiLoKo opened this issue 10 years ago • 4 comments

I'm not quite sure what this search module is supposed to be doing.

When I type in g - 3rd result goes away an 2 remain. But only the first result has a g in the sys.argv line ...

Where does it search ? Where should it be searching ? Do we want an advanced search ?

  • I think it'd be better to have a series of toggle buttons with all severities (INFO, NORMAL, MAJOR) to show/hide each of them.
  • It's be nice to make a multi select choice box (from chosen library maybe?) which allows us to choose which bears to show.
  • Glob based search for files ? Along with a line range search
  • And a search box for test based (for result messages OR code line that's affected itself)

AbdealiLoKo avatar Feb 27 '16 02:02 AbdealiLoKo

both the results actually contain g, first one has sys.argv[1], while the second one has print sys.argv in its diff data. I think that the current search in working correctly but we can modify the search by defining some custom filters with the upgraded features, like severity?

rishabhs95 avatar Mar 10 '16 05:03 rishabhs95

@rishabhs95 Well noticed! :smile: Btw currently we are considering severity ( and a few more factors too) while filtering search results. Actually severity are numbers [1..3], so they can be searched only via numbers. It's bad from UX perspective though. We'll fix it soon. Possibly, the ambiguity will be cleared once issues like https://github.com/coala-analyzer/coala-html/issues/20 are solved. Feel free to let us know if you wanna send PR?:)

tushar-rishav avatar Mar 10 '16 06:03 tushar-rishav

okay, so I will start working with bug #20 then?

rishabhs95 avatar Mar 10 '16 16:03 rishabhs95

@rishabhs95 Sure! Go ahead. I've assigned you!

tushar-rishav avatar Mar 10 '16 17:03 tushar-rishav