coAST icon indicating copy to clipboard operation
coAST copied to clipboard
verified publisher icon coala

data/Language/Flow.yaml: Add Flow definition

Open utkarsh2102 opened this issue 7 years ago • 17 comments

This adds definition of Flow, a static type checker for JS.

Closes #51

utkarsh2102 avatar Dec 05 '18 00:12 utkarsh2102

@gitmate-bot rebase

jayvdb avatar Dec 05 '18 08:12 jayvdb

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

jayvdb avatar Dec 05 '18 08:12 jayvdb

Automated rebase with GitMate.io was successful! :tada:

jayvdb avatar Dec 05 '18 08:12 jayvdb

this language has no keywords?

Flow is just a static type checker for JS. So thought of skipping the same. Should I add it?

utkarsh2102 avatar Dec 05 '18 16:12 utkarsh2102

Flow is just a static type checker for JS.

coAST is about creating models to describe stuff. Not about omitting information.

jayvdb avatar Dec 05 '18 16:12 jayvdb

Flow is just a static type checker for JS.

coAST is about creating models to describe stuff. Not about omitting information.

Duly noted. Will add them. Do reply to the comments inline, too.

utkarsh2102 avatar Dec 05 '18 16:12 utkarsh2102

I have no intention of giving more feedback at this stage, as you have not yet attempted to model the language.

jayvdb avatar Dec 05 '18 16:12 jayvdb

Will do, thanks.

utkarsh2102 avatar Dec 05 '18 16:12 utkarsh2102

Comment on 6a22f54fd6eb8617d239748d2219de99f061cf4d, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

jayvdb avatar Dec 12 '18 17:12 jayvdb

Comment on 6a22f54, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

This is not related to this PR. Moreover, this has been fixed already.

utkarsh2102 avatar Dec 12 '18 18:12 utkarsh2102

Needs rebase :)

li-boxuan avatar Dec 13 '18 11:12 li-boxuan

Needs rebase :)

Rebased. How does it look now?

utkarsh2102 avatar Dec 13 '18 12:12 utkarsh2102

@li-boxuan, done as asked :D Could you take a look now?

utkarsh2102 avatar Dec 13 '18 15:12 utkarsh2102

Netlify is failing due to other reason now :)

li-boxuan avatar Dec 14 '18 01:12 li-boxuan

Netlify is failing due to other reason now :)

My bad. Resolved, @li-boxuan. Let me know if there's any other issue in this PR.

utkarsh2102 avatar Dec 14 '18 05:12 utkarsh2102

Rebased, too.

utkarsh2102 avatar Dec 15 '18 17:12 utkarsh2102

I was about to point out what @li-boxuan did, but it looks good now. The new modeling fixes this up.

pythongiant avatar Dec 16 '18 16:12 pythongiant