coAST icon indicating copy to clipboard operation
coAST copied to clipboard
verified publisher icon coala

update README.md

Open Marco2018 opened this issue 7 years ago • 6 comments

README.md: Fix docstring typo

avoid -->avoiding

Closes https://github.com/coala/coAST/issues/99

Marco2018 avatar Jan 18 '19 09:01 Marco2018

Hi @shashank-b Thank you for your suggestions. It is my first time to contribute in an open source project. I will go through commit guidelines and newcomer's guide and modify it afterward. Thanks!

Marco2018 avatar Jan 20 '19 06:01 Marco2018

Hi @shashank-b I have read both commit guidelines and newcomer's guide and modified my commit message as you suggested. But I am not sure how to squash my commits. Can I just fork this project to my Github once again? Thanks, it's my first time to make a PR. I really appreciate your help.

Marco2018 avatar Jan 29 '19 10:01 Marco2018

Hey! @KVGarg Thank you for your help. I have tried to squash my commits into one. So I reset back the branch and commit once again. It seems commits are squashed into one commit. Is it acceptable for this PR? So sorry I made this PR a little bit complicated. THX!

Marco2018 avatar Mar 23 '19 08:03 Marco2018

Yeah @Marco2018 For further any changes to existing commit you can use git commit —amend to avoid creating more than one commit for a PR/issue

KVGarg avatar Mar 24 '19 00:03 KVGarg

@KVGarg Thanks!

Marco2018 avatar Mar 25 '19 12:03 Marco2018

Won't be able to rebase as the PR was created from master. @Marco2018 please rebase if you can.

abhishalya avatar May 18 '21 09:05 abhishalya