radar icon indicating copy to clipboard operation
radar copied to clipboard

Radar customisation

Open danielsilverstone-ct opened this issue 3 years ago • 5 comments

This branch does a company cleanup chore, and then introduces a refactor which permits radar settings to control the number, name, color, and labels, of the levels in the radars. Some companies use different schemes for technology radars and this way it is configurable.

I have done my best to ensure that things are the same for the CNCF radars. The SVGs are a few pixels different in size because previously they had been human-rounded whereas now they're mathematically chosen.

danielsilverstone-ct avatar Aug 18 '22 15:08 danielsilverstone-ct

Hi Daniel. I'm having a bit of trouble understanding what this PR does. Is it possible to provide some examples/screenshots to make it clear?

Also, I should mention there's a project underway to move the CNCF radars in to the www.cncf.io site and take down the main CNCF radar site. I'm not sure if that affects you or whether you use this radar code on a different implementation.

cjyabraham avatar Oct 03 '22 23:10 cjyabraham

Hey Chris, sorry for the delay, I was on vacation and then at a conference. This PR is basically trying to make it possible to customise the names/labels of the levels used in radars. In order to ensure that linting etc. all works, it's a tad more far-reaching than just a relabelling effort at the SVG generation step. As an example, CNCF radars only show adopt/trial/assess whereas my client needed four levels (with different names) to match their internal tech catalogue.

Regarding the intention to move away from an independent radar site; if there were an intent, perhaps, to turn this repository into a library for loading/validating/rendering radars then we might be able to continue to cooperate. If on the other hand the intention is to move even further away from reusability then I guess we'll have to continue with a fork.

I can't trivially provide screenshots of the radars in use in my client; but I can try and mock some up with fake data if that will help you.

danielsilverstone-ct avatar Oct 18 '22 14:10 danielsilverstone-ct

Hi @danielsilverstone-ct. Your changes make sense 👍. Thanks.

I'm not sure what the plan is for this repo following our migration of CNCF radars into the cncf.io site but I assumed it would just be archived. I'll defer, however, to @caniszczyk on this.

cjyabraham avatar Oct 18 '22 16:10 cjyabraham

ping Taylor D as he owns radars now

We should definitely keep the radars public, the repo could be archived but I'd wait honestly until 2023

On Tue, Oct 18, 2022 at 12:42 PM Chris Abraham @.***> wrote:

Hi @danielsilverstone-ct https://github.com/danielsilverstone-ct. Your changes make sense 👍. Thanks.

I'm not sure what the plan is for this repo following our migration of CNCF radars into the cncf.io site but I assumed it would just be archived. I'll defer, however, to @caniszczyk https://github.com/caniszczyk on this.

— Reply to this email directly, view it on GitHub https://github.com/cncf/radar/pull/68#issuecomment-1282689425, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIL32SF7M4XZQWVTIC3WD3HOLANCNFSM565U5KYA . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk avatar Oct 18 '22 16:10 caniszczyk

Sounds fine. Our plan does include migrating the existing radars into the cncf.io site so they do remain public.

cc @onlydole

cjyabraham avatar Oct 18 '22 16:10 cjyabraham