docker-stack icon indicating copy to clipboard operation
docker-stack copied to clipboard
verified publisher icon cmtickle

Apedik/varnish production mode

Open apedicdev opened this issue 2 years ago • 2 comments

Added varnish on production mode, in case you wanted merge or have a separate branch

apedicdev avatar Sep 13 '23 10:09 apedicdev

Hi @apedicdev,

There is functionality in the scripts to piggy-back the magento deploy:mode:set and copy files in to enable production mode. here : https://github.com/cmtickle/docker-stack/blob/master/project/includes/_functions_m2.sh#L249

I feel it would be better if this functionality was added by extending there. The primary use of this docker-stack is as a development environment, these changes would potentially make things more difficult whilst developing.

Please let me know what you think?

cmtickle avatar Sep 14 '23 08:09 cmtickle

@cmtickle it definitely makes sense, that's why I had created a separated branch, in case we would like to test production mode with varnish full page cache enabled. I will have a look how to extend the included functionality and possibly merge it to master once it can be enabled/disabled easily

apedicdev avatar Sep 14 '23 09:09 apedicdev