cms icon indicating copy to clipboard operation
cms copied to clipboard

Add "reevaluate keeping sandbox" button to AWS

Open wil93 opened this issue 8 years ago • 3 comments

We have these 3 buttons:

schermata da 2017-04-21 08-31-27

We could add another button (possibly: that appears only for single submissions, and not when bulk-reevaluating) so that it looks like this: [C] [E] [E+] [S]. The "E+" button reevaluates without deleting the sandbox afterwards. This is useful to avoid having to change the keep_sandbox setting in cms.conf and restart everything when we only need to debug 1 weird-behaving submission.

If you're wondering "shouldn't we do the same for [C+]?", then yes, maybe, I would agree either way. It would be OK for me to just have [C] [C+] [S], since I have been saying for a long time that I don't think we should even store executable binaries in the DB (thus making the "compilation/evaluation" distinction not that relevant).

wil93 avatar Apr 21 '17 06:04 wil93

I think a script would be much more suitable for this purpose. This feature is most likely used by developers and putting it in AWS might be confusing. Also, ultimately you will need to login to the server for inspecting the sandbox.

As a script however, this would be very great to have.

akmohtashami avatar Apr 21 '17 07:04 akmohtashami

Yeah, good idea 👍

The script could work like this:

cmsDebugSubmission <id> -o <folder>

And, inside <folder>, it could create neatly numbered sandbox folders (instead of random tmpXXXXX names). This is good in order to understand which is the compilation sandbox, and to understand how the sandbox are ordered (I would say: number them by testcase codename)

wil93 avatar Apr 21 '17 07:04 wil93