cms icon indicating copy to clipboard operation
cms copied to clipboard

Make no-conf apply to isolate config as well

Open ranaldmiao opened this issue 4 years ago • 3 comments

Currently, when running sudo python3 prerequisites.py install --no-conf, configuration files for isolate will be re-installed.

This PR introduces a change for --no-conf to also be applied to isolate configuration files. When --no-conf argument is provided, isolate configuration files will not be installed.


This change is Reviewable

ranaldmiao avatar Apr 10 '21 13:04 ranaldmiao

Codecov Report

Merging #1175 (ccf69c7) into master (98cf097) will increase coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
+ Coverage   63.64%   63.70%   +0.05%     
==========================================
  Files         232      232              
  Lines       17046    17046              
==========================================
+ Hits        10849    10859      +10     
+ Misses       6197     6187      -10     
Flag Coverage Δ
functionaltests 47.59% <ø> (+0.01%) :arrow_up:
unittests 44.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cms/server/contest/handlers/contest.py 86.40% <0.00%> (-3.89%) :arrow_down:
cms/server/contest/handlers/tasksubmission.py 48.63% <0.00%> (-1.64%) :arrow_down:
cms/service/workerpool.py 70.00% <0.00%> (-1.12%) :arrow_down:
cms/db/fsobject.py 76.51% <0.00%> (-0.76%) :arrow_down:
cms/db/submission.py 97.93% <0.00%> (-0.52%) :arrow_down:
cms/io/rpc.py 93.19% <0.00%> (-0.35%) :arrow_down:
cms/db/filecacher.py 77.41% <0.00%> (ø)
cms/server/admin/handlers/base.py 69.63% <0.00%> (+0.66%) :arrow_up:
cms/grading/Job.py 90.17% <0.00%> (+0.89%) :arrow_up:
cms/service/ProxyService.py 68.68% <0.00%> (+1.01%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98cf097...ccf69c7. Read the comment docs.

codecov[bot] avatar Apr 10 '21 13:04 codecov[bot]

Thanks.

The general idea is good, but I think it breaks the

./prerequisites.py install_isolate

subcommand. This should be easy to fix, though.

andreyv avatar Apr 13 '21 15:04 andreyv

Thanks.

The general idea is good, but I think it breaks the

./prerequisites.py install_isolate

subcommand. This should be easy to fix, though.

Good point, let me fix that and update you

ranaldmiao avatar Apr 13 '21 15:04 ranaldmiao