cms icon indicating copy to clipboard operation
cms copied to clipboard

Implement support for task statement in HTML and MD

Open wil93 opened this issue 7 years ago • 5 comments

I tested adding (from AWS and from CLI) and removing (from AWS), and tested the rendering.

If you like this change, I think the only change needed is to write the DB updater (and "vendorize" the new JS dependencies, I didn't do it here because I didn't want to push big files).

  • [ ] make sure that AWS supports uploading the new statement types
  • [ ] fix cmsAddStatement not fetching assets

This change is Reviewable

wil93 avatar Nov 29 '18 14:11 wil93

FWIW, we are already using Markdown for task statements. We using pandoc and a .tex template in the middle, so we generate the task statements separately with a Makefile.

CristianCantoro avatar Dec 02 '18 19:12 CristianCantoro

Example statement in Markdown, with PDF output:

CristianCantoro avatar Dec 02 '18 20:12 CristianCantoro

Let's try to merge #1067 first

stefano-maggiolo avatar Dec 07 '18 21:12 stefano-maggiolo

Now that #1067 is merged, maybe this can be considered :smiley:

wil93 avatar Jan 16 '19 12:01 wil93

Codecov Report

Merging #1086 into master will decrease coverage by 19.89%. The diff coverage is 19.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   61.99%   42.09%   -19.9%     
==========================================
  Files         228      230       +2     
  Lines       16460    16711     +251     
==========================================
- Hits        10204     7035    -3169     
- Misses       6256     9676    +3420
Flag Coverage Δ
#functionaltests ?
#unittests 42.09% <19.54%> (-1.07%) :arrow_down:
Impacted Files Coverage Δ
cms/server/admin/handlers/__init__.py 0% <ø> (-100%) :arrow_down:
cms/server/contest/handlers/__init__.py 100% <ø> (ø) :arrow_up:
cms/server/admin/handlers/task.py 0% <0%> (-41.02%) :arrow_down:
cms/db/__init__.py 96.42% <100%> (ø) :arrow_up:
cms/__init__.py 100% <100%> (ø) :arrow_up:
cms/server/contest/handlers/task.py 31.25% <12.19%> (-12.23%) :arrow_down:
cmscontrib/AddStatement.py 21.66% <20%> (-51.42%) :arrow_down:
cmscontrib/loaders/italy_yaml.py 7.89% <8.33%> (-0.06%) :arrow_down:
cms/db/task.py 73.15% <91.66%> (-8.6%) :arrow_down:
cms/server/admin/__init__.py 0% <0%> (-100%) :arrow_down:
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6e7a87...fd0acd8. Read the comment docs.

codecov[bot] avatar Mar 03 '20 23:03 codecov[bot]