cmder icon indicating copy to clipboard operation
cmder copied to clipboard

[Bug] development builds `cmder.exe` always overwrites the terminal emulator settings files.

Open 296951 opened this issue 1 year ago • 11 comments

Version Information

Cmder version: development
Operating system: Windows 11

Cmder Edition

Development branch.

Description of the issue

The user settings file for the terminal emulator is always being overwritten in the development branch

How to reproduce

  1. Edit/Add a profile/task in Windows Terminal or ConEmu.
  2. Close Windows Terminal or ConEmu
  3. Run cmder.exe
  4. Profile Edits/Adds are lost.

Additional context

No response

Checklist

  • [X] I have read the documentation.
  • [X] I have searched for similar issues and found none that describe my issue.
  • [X] I have reproduced the issue on the latest version of Cmder.
  • [X] I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.

296951 avatar May 29 '24 15:05 296951

Working on it...

daxgames avatar May 29 '24 18:05 daxgames

I must have had an OLD Cmder.exe the currently compiled exe works fine.

daxgames avatar May 30 '24 19:05 daxgames

So the profile creation is done using the launcher?

Quick q. would it also make sense to add the profile to the global WT itself in the mini versions as well... for people that don't want to include a duplicate WT on their machines BTW

DRSDavidSoft avatar May 30 '24 19:05 DRSDavidSoft

So the profile creation is done using a launcher?

Yes - Always has even for ConEmu

Cmder.exe copies a Default ConEmu.xml or a settings.json if they do not exist.

Quick q. would it also make sense to add the profile to the global WT itself in the mini versions as well... for people that don't want to include a duplicate WT on their machines BTW

I don't understand the question. The cmder-mini distributions include either ConEmu or Windows Terminal depending in which distro is downloaded.

UNRELEASED - Cmder for Windows is micro compared to mini as it does not include a terminal emulator and uses native Cmd.exe/Powershell.exe shells pre-installed with Windows or Git Bash.

See PR #2942

daxgames avatar May 30 '24 19:05 daxgames

@daxgames "Micro" would be my pesonal favorite as it would include the core Cmder features (e.g. profiles & clink) and leave the terminal to the end-user

DRSDavidSoft avatar May 30 '24 19:05 DRSDavidSoft

@DRSDavidSoft Cmder for Windows is just that EXCEPT it uses Cmd.exe, Powershell.exe, and bash.exe or mintty.exe. There is ZERO configuration to say launch these in ConEmu or Windows Terminal or ANY other terminal emulator.

daxgames avatar May 30 '24 20:05 daxgames

This is worse than I originally thought. ConEmu is busted too.

daxgames avatar May 31 '24 21:05 daxgames

This is worse than I originally thought. ConEmu is busted too.

Is this issue only in dev branch or is master also affected?

DRSDavidSoft avatar Aug 19 '24 00:08 DRSDavidSoft

I have not looked at master. I just looked at this again the other day I will look at master and get back to you.

I think it is ready to merge but let me put some more time into it.

daxgames avatar Aug 19 '24 01:08 daxgames

@DRSDavidSoft This is not in master. The PR should be ready to merge if the latest commit builds. It builds and works for me locally.

daxgames avatar Aug 20 '24 12:08 daxgames

I still have to review the dev build, I'm assigning some tome to do so. Then we can be sure to merge develop with master. Thanks.

DRSDavidSoft avatar Aug 20 '24 15:08 DRSDavidSoft