cmder icon indicating copy to clipboard operation
cmder copied to clipboard

Use Github Actions to build and release

Open MartiUK opened this issue 3 years ago • 9 comments

Fixes #2723 Fixes #2729

MartiUK avatar Jul 18 '22 16:07 MartiUK

Did Appveyor discontinue some part of their service offering that broke this?

daxgames avatar Jul 18 '22 16:07 daxgames

Looking into it but yeah it's likely they don't install the older platform tools now

MartiUK avatar Jul 18 '22 16:07 MartiUK

AppVeyor is pretty dead yeah, might be easier if we just switched to GitHub Actions?

Stanzilla avatar Jul 18 '22 18:07 Stanzilla

That would be my preference too

MartiUK avatar Jul 18 '22 18:07 MartiUK

@MartiUK @Stanzilla Hey guys do either of you know the secret sauce to be able to compile the launcher locally on Windows running VS Community(any version).

I have never been able to use `scripts\build.ps1:

image

I figured out on an old windows install with VS Community 2017 but I am getting the below when I try now with Visual Studio Community 2022:

image

Asking here because I hope you guys can save me time of digging to figure it out again.

daxgames avatar Sep 01 '22 13:09 daxgames

I haven't done that in ages but your first error message looks like you are missing or having a wrong version of the Windows SDK?

Also I faintly remember that I did not use build.ps1 but just hit compile in VS

Stanzilla avatar Sep 01 '22 16:09 Stanzilla

@stanzilla I actially found my old laptop that has vs community 2019 on it and both script and gui work fine.

No such luck with vs community 2022 even though it appears I have all SDK installed correctly. Probably missing one small piece.

Thanks for the reply.

daxgames avatar Sep 01 '22 21:09 daxgames

@Stanzilla I figured out how to get it to build on VS Comunity 2022.

I had to change the platform tools in the UI to something then change them back to the original. This allows it to build in the UI.

Then for scripts/build.ps1 to work I had to open the x64 Native Tools Command Prompt for VS 2022 Start Menu shortcut, run powershell, then run scripts/build.ps1 -compile .

Initially I was launching the Developer PowerShell for VS 2022 Start menu shortcut and running scripts/build.ps1 -compile which failed with the windows.h not found error.

I am obviously not a proficient Visual Studio user! 👍

daxgames avatar Sep 04 '22 14:09 daxgames

I've been busy with work recently but I was working on the build scripts as well to work with the latest Windows SDK, but thanks @daxgames

MartiUK avatar Sep 06 '22 09:09 MartiUK

@MartiUK I added an initial GitHub Actions workflow to build Cmder using GitHub, however there are some known limitations regarding artifacts (e.g. it seems that zipped artificats) are doubly created, i.e. once by Cmder build scripts and one more time by GitHub actions)

DRSDavidSoft avatar Oct 14 '22 23:10 DRSDavidSoft