Matthew Craven

Results 74 comments of Matthew Craven

If the cost of copying some bytearray is significant, it usually makes sense to tell the GC not to copy it, by pinning that bytearray. So I don't find the...

> > I've been thinking for a while about removing most of the near-duplication between our `ByteString` and `ShortByteString` code, by writing both with identical combinators at different types. I...

Well... * Explicit pinning is typically not required for buffers larger than around 3-4K, and an extra copy of a small buffer while performing an IO operation is probably not...

Thanks anyway for trying, @cbclemmer!

At this point the `bytestring-0.11` branch will only receive bug fixes, and not new features.

Re-targeting against bytestring `master` is a pre-requisite for merging. Every ghc version since 8.0 is still compatible; use which-ever you like.

Perhaps the way to support this is a higher-order interface that takes `displayExponent :: Int -> Builder`. Then you could write such a function that prints an exponent of `0`...

> @clyring I have been unable to make your suggestion performant. I have tried several ways but am consistently getting results that are 150-300% slower. Could you make some recommendations...

* (1) I'm also not very happy with the amount of un-shared logic between the `Float` and `Double`-formatting code. But using classes to de-duplicate this logic may require considerable care...

I see you're doing a lot of work in various PRs in this area. Please let me know when each one is ready for review, and which ones to start...