Christian Luhmann

Results 61 comments of Christian Luhmann

Is the issue here with `pm.do() ` or with `pm.observe()`? The usage of `pm.do()` in the example seems to run without a problem. The call to `pm.observe()` fails if `observed=np.random.randn(50)`,...

This limitation particularly odd in that it seems like it prevents users from `observe()`ing MutableData, correct? Definitely not intuitive why this is invalid (`set_data()` and `observe()` seem strongly related). Furthermore,...

Does https://github.com/pymc-labs/pymc-marketing/pull/933 address this?

I put together a toy MMM (from the MMM example notebook) and then optimized using this: ```python response_30 = mmm.allocate_budget_to_maximize_response( budget=5230, num_periods=30, time_granularity="daily", ) ``` which is identical to the...

Seems kind of cool. There have definitely been questions about this on discourse.

Is `target_accept` a kwarg to `pm.sample()` or just another `**kwargs`? The argument isn't even [included in the API docs](https://www.pymc.io/projects/docs/en/stable/api/generated/pymc.sample.html), so if it's the former, there's a bigger problem. I mean,...

Exactly. But those are each specified separately and, it turns out, in a way that creates different defaults for different algorithms. So I'm not sure what's missing from the docs.

This is caused by `pm.sample()` being a franken-wrapper that dispatches to a bunch of actual sampling methods, but seems like it does something useful all on its own. Where would...

But ... it's not an argument to `pm.sample()`. I do have a better idea, but you didn't like it (e.g., deprecate `pm.sample`). :joy: