php-redis-server icon indicating copy to clipboard operation
php-redis-server copied to clipboard
verified publisher icon clue

[WIP] Implement Blocking lists.

Open pwhelan opened this issue 8 years ago • 3 comments

I finished the blocking lists implementation. In the process I had to upgrade and add the following packages:

  • Promises
  • Evenement
  • Clue\React\Block

I created a wrapper class for SplDoublyLinkedList with the EventEmitterTrait. That should make how I implementated it pretty obvious.

pwhelan avatar Jun 15 '17 15:06 pwhelan

@pwhelan Thanks for your work, I really like the progress you're making here!

I'll mark this as WIP for now and will keep an eye on this. Make sure to send me a ping and/or remove the WIP marker if you have any questions or feel this needs a review :+1:

clue avatar Jun 16 '17 17:06 clue

Yeah. I've had to repeatedly rethink the approach behind it. It seems to be good enough now to run the unit tests for one of my projects. I also have a hashes branch based off of this one.

pwhelan avatar Jun 16 '17 20:06 pwhelan

@clue the one last remaining bit to fix is with the timeouts. I was thinking of somehow exposing the timeout value to the Invoker, thoughts?

pwhelan avatar Jun 19 '17 19:06 pwhelan