kitex icon indicating copy to clipboard operation
kitex copied to clipboard

fix: use detection transHandler in windows os to support grpc

Open ppzqh opened this issue 3 years ago • 1 comments

What type of PR is this?

fix

Check the PR title.

  • [x] This PR title match the format: <type>(optional scope): <description>
  • [x] The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

fix: windows 环境下 server 初始化 detection transHandlerFactory,以支持 grpc 协议。

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: zh(optional):

Which issue(s) this PR fixes:

[#673]

ppzqh avatar Oct 12 '22 09:10 ppzqh

Codecov Report

Base: 61.99% // Head: 61.92% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (c840e18) compared to base (08c2413). Patch coverage: 62.50% of modified lines in pull request are covered.

:exclamation: Current head c840e18 differs from pull request most recent head 385a9c7. Consider uploading reports for the commit 385a9c7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #677      +/-   ##
===========================================
- Coverage    61.99%   61.92%   -0.08%     
===========================================
  Files          212      212              
  Lines        16408    16413       +5     
===========================================
- Hits         10172    10163       -9     
- Misses        5267     5272       +5     
- Partials       969      978       +9     
Impacted Files Coverage Δ
pkg/remote/trans/nphttp2/grpc/http2_client.go 71.54% <50.00%> (-0.55%) :arrow_down:
pkg/remote/trans/nphttp2/server_handler.go 64.17% <60.00%> (-0.71%) :arrow_down:
pkg/remote/trans/detection/server_handler.go 52.38% <62.50%> (ø)
pkg/remote/trans/nphttp2/conn_pool.go 73.73% <100.00%> (ø)
pkg/warmup/pool_helper.go 93.75% <0.00%> (-2.09%) :arrow_down:
pkg/remote/trans/nphttp2/grpc/controlbuf.go 82.56% <0.00%> (-0.67%) :arrow_down:
pkg/remote/trans/nphttp2/grpc/http2_server.go 69.39% <0.00%> (-0.49%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 12 '22 09:10 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 22 '22 06:11 CLAassistant