hertz icon indicating copy to clipboard operation
hertz copied to clipboard

fix: ignore body should not set content-length

Open byene0923 opened this issue 3 years ago • 1 comments

What type of PR is this?

fix

Check the PR title.

  • [x] This PR title match the format: <type>(optional scope): <description>
  • [x] The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: can refer to https://github.com/valyala/fasthttp/pull/1022, fasthttp only handle ContinueReadBody(), this pr also handle ContinueReadBodyStream() zh(optional): fasthttp 只处理了 ContinueReadBody(), 这里添加了对 ContinueReadBodyStream() 的处理 和 测试

Which issue(s) this PR fixes:

close #320

byene0923 avatar Oct 24 '22 14:10 byene0923

Codecov Report

Base: 66.14% // Head: 66.13% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (4211ea3) compared to base (3a83d2e). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #321      +/-   ##
===========================================
- Coverage    66.14%   66.13%   -0.01%     
===========================================
  Files           85       85              
  Lines         8317     8319       +2     
===========================================
+ Hits          5501     5502       +1     
- Misses        2456     2458       +2     
+ Partials       360      359       -1     
Impacted Files Coverage Δ
pkg/protocol/http1/req/request.go 61.88% <100.00%> (+1.88%) :arrow_up:
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 24 '22 14:10 codecov[bot]