eino icon indicating copy to clipboard operation
eino copied to clipboard

Bug: Compatibility issues with the kin-openapi version

Open Whitea029 opened this issue 8 months ago • 1 comments

Describe the bug

The current version of github.com/getkin/kin-openapi used in this repository is v0.118.0.

However, kin-openapi has already been updated to v0.132.0. One notable breaking change is that schema.Type is no longer of type string, but rather schema.Types, which is defined as []string.

upstream kin-openapi repository relevant codes: https://github.com/getkin/kin-openapi/blob/master/openapi3/schema.go#L91

This causes compatibility issues in the current codebase, as it still relies on schema.Type being a string.

Relevant lines:

  • https://github.com/cloudwego/eino/blob/main/schema/tool.go#L123C4-L123C36
  • https://github.com/cloudwego/eino/blob/main/schema/tool.go#L159C1-L165C3
  • https://github.com/cloudwego/eino/blob/main/components/tool/utils/create_options.go#L165C2-L169C36

Expected behavior

Please consider upgrading the kin-openapi dependency to the latest version and adjusting the related code accordingly to maintain compatibility.

Version

cloudwego/eino version: v0.3.37

Additional context

If helpful, I'm happy to submit a PR to help upgrade the dependency and make the necessary code changes.

Thanks!

Whitea029 avatar May 24 '25 02:05 Whitea029

Hi, the reason for locking this repo version at v0.118.0 is that for compatibility, Eino locked the Go version at 1.18, and this repo used features after Go 1.18 in version v0.118.0.

We may upgrade eino to a major version later, improve eino's Go version, and update the version of kin-openapi.

meguminnnnnnnnn avatar May 26 '25 03:05 meguminnnnnnnnn

I have unfortunately the same issue

Kamysek avatar Jun 06 '25 08:06 Kamysek