components icon indicating copy to clipboard operation
components copied to clipboard

[Feature Request]: Tokens to manipulate rounded corners

Open bolora opened this issue 3 years ago • 4 comments

Description

The visual refresh theme is great but there will be consumers of Cloudspace that require a design system without rounded corners or may need to adjust the size or rounded corners.

Consumers should be able to:

  • Globally control rounded corners in the entire system with a single boolean value. It should be set to true by default. Setting the token to false will automatically set all tokens that affect border-radius to 0. Twitter Bootstrap has this feature and it is simple enacted by overriding this scss variable: https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss#L338
  • There should be tokens to adjust rounded corner values. Something like base, small, medium, large, etc. For example, a consumer may want to reduce the roundness of the primary button. Right now the only way to do this is to create a custom class to hack the original qualities of buttons or any other rounded UI element.

Code of Conduct

bolora avatar Jul 23 '22 12:07 bolora

Hey Bo,

thank you for reaching out. A theme-able design token for border radius on various component groups seems like a reasonable addition to the theming capabilities. However, we currently don't have any plans for making this change.

I will keep this issue open to collect any additional feedback. Feel free to share more information about your use case for theme-able border radius and how you would use it in your application.

Thank you, Florian

FlorianDr avatar Jul 25 '22 15:07 FlorianDr

~~Thanks for the explanation @FlorianDr. Would you accept the change in the form of a PR?~~

Answered my own question in the Contribution guide. No, PRs are not accepted for enhancements. How long will this be the case?

lasley avatar Jul 25 '22 16:07 lasley

That's correct! For now, we don't accept PRs for enhancements, until we have found a good contribution model both for contributors and maintainers. Do you already have a fork/PR ready?

FlorianDr avatar Jul 27 '22 15:07 FlorianDr

@FlorianDr - not at this time; I'd like to avoid effort if it won't be accepted. We're in the process of identifying whether CloudScape will work for our use case, and rounded corners was one of the reasons it wouldn't. This issue was a test of waters to understand how/if our needs could be integrated into this design system before making an adoption choice.

lasley avatar Jul 29 '22 14:07 lasley

@bolora @lasley we have just released public and themeable design tokens for border radius. In our documentation website you can find:

fralongo avatar Sep 08 '22 09:09 fralongo