components icon indicating copy to clipboard operation
components copied to clipboard

fix: Click outside of area chart closes popover

Open Al-Dani opened this issue 3 years ago • 1 comments

Description

Ensure that after clicking outside of a chart component, highlighted segment will be cleared and popover will be dismissed.

Follow-up for #592

How has this been tested?

New integration test.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Al-Dani avatar Dec 28 '22 10:12 Al-Dani

Codecov Report

Base: 92.73% // Head: 92.72% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (5252788) compared to base (079032c). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   92.73%   92.72%   -0.02%     
==========================================
  Files         572      572              
  Lines       16470    16474       +4     
  Branches     4525     4526       +1     
==========================================
+ Hits        15274    15275       +1     
- Misses       1120     1124       +4     
+ Partials       76       75       -1     
Impacted Files Coverage Δ
src/area-chart/model/use-chart-model.ts 85.22% <0.00%> (-1.48%) :arrow_down:
src/table/use-mouse-down-target.ts
src/internal/hooks/use-mouse-down-target.ts 100.00% <0.00%> (ø)
src/cards/index.tsx 95.00% <0.00%> (+0.05%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Dec 28 '22 10:12 codecov[bot]