components icon indicating copy to clipboard operation
components copied to clipboard

fix: Handle dynamic cells within table

Open gethinwebster opened this issue 1 year ago • 1 comments

Description

** Currently in draft - still experimenting **

This improves handling of cells with dynamic content, to ensure that column widths are recalculated when this content changes.

Related links, issue #, if available: AWSUI-52826

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gethinwebster avatar Aug 05 '24 09:08 gethinwebster

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (18f9246) to head (c8e27e8). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/table/header-cell/index.tsx 83.33% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2543      +/-   ##
==========================================
- Coverage   96.20%   96.19%   -0.01%     
==========================================
  Files         761      761              
  Lines       21430    21436       +6     
  Branches     7331     7324       -7     
==========================================
+ Hits        20616    20620       +4     
- Misses        761      808      +47     
+ Partials       53        8      -45     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 05 '24 09:08 codecov[bot]