components icon indicating copy to clipboard operation
components copied to clipboard

chore: Remove removeHighContrastHeader global flag

Open fralongo opened this issue 2 years ago • 1 comments

Description

  • depends on https://github.com/cloudscape-design/components/pull/2150
  • will not be merged to mainline. Several PRs will be merged at the same time in the future

How has this been tested?

Locally

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates. N/A
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md. N/A
  • Changes do not include unsupported browser features, see CONTRIBUTING.md. N/A
  • Changes were manually tested for accessibility, see accessibility guidelines. N/A

Security

Testing

  • Changes are covered with new/existing unit tests? N/A
  • Changes are covered with new/existing integration tests? N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fralongo avatar Apr 12 '24 08:04 fralongo

Besides the removal of the dark header background, the Backstop tests also show a difference in the header heights; is this expected?

(Although if there is an issue, I don't think it comes from this PR in particular)

Will doubke-check, thank you for reporting. Indeed, there are failures coming from previous PRs that I need to investigate

fralongo avatar Apr 15 '24 08:04 fralongo