components
components copied to clipboard
Kg/slider popover
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
- Changes include appropriate documentation updates.
-
Changes are backward-compatible if not indicated, see
CONTRIBUTING.md. -
Changes do not include unsupported browser features, see
CONTRIBUTING.md. - Changes were manually tested for accessibility, see accessibility guidelines.
Security
-
If the code handles URLs: all URLs are validated through the
checkSafeUrlfunction.
Testing
- Changes are covered with new/existing unit tests?
- Changes are covered with new/existing integration tests?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Attention: Patch coverage is 64.86486% with 39 lines in your changes are missing coverage. Please review.
Project coverage is 94.69%. Comparing base (
03232b7) to head (e2c1200). Report is 57 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| src/slider/index.tsx | 60.63% | 36 Missing and 1 partial :warning: |
| src/popover/container.tsx | 88.23% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2051 +/- ##
==========================================
- Coverage 94.78% 94.69% -0.09%
==========================================
Files 661 678 +17
Lines 17943 18383 +440
Branches 5933 6110 +177
==========================================
+ Hits 17007 17408 +401
- Misses 871 909 +38
- Partials 65 66 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.