components icon indicating copy to clipboard operation
components copied to clipboard

fix: Removes unused ariaLabel from Cards

Open Al-Dani opened this issue 2 years ago • 2 comments

Description

selectionGroupLabel doesn't do anything in Cards.

Probably the result of copy-paste from Table. In Table it is used to label "select all" checkbox. In cards we do not have this functionality.

Related links, issue #, if available: AWSUI-20273

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Al-Dani avatar Sep 06 '23 14:09 Al-Dani

ok, I just realised we cannot remove this because it's a breaking change...

I guess we can put @deprecated and explain that property has no effect

Al-Dani avatar Sep 06 '23 18:09 Al-Dani

Codecov Report

Patch coverage has no change and project coverage change: +0.01% :tada:

Comparison is base (4df7f8d) 93.98% compared to head (3f624d4) 93.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   93.98%   93.99%   +0.01%     
==========================================
  Files         642      642              
  Lines       17334    17332       -2     
  Branches     5695     5694       -1     
==========================================
  Hits        16291    16291              
+ Misses        973      971       -2     
  Partials       70       70              
Files Changed Coverage Δ
src/cards/index.tsx 93.82% <ø> (-0.15%) :arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 06 '23 19:09 codecov[bot]