components icon indicating copy to clipboard operation
components copied to clipboard

WIP - moving drawers out of beta

Open katiegeorge opened this issue 2 years ago • 1 comments

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

katiegeorge avatar Aug 31 '23 22:08 katiegeorge

Codecov Report

Patch coverage: 94.23% and project coverage change: -0.07% :warning:

Comparison is base (82b4c9c) 93.98% compared to head (d04e1ae) 93.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1497      +/-   ##
==========================================
- Coverage   93.98%   93.92%   -0.07%     
==========================================
  Files         643      643              
  Lines       17350    17374      +24     
  Branches     5700     5718      +18     
==========================================
+ Hits        16307    16319      +12     
- Misses        974      986      +12     
  Partials       69       69              
Files Changed Coverage Δ
src/app-layout/utils/use-resize.tsx 100.00% <ø> (+8.33%) :arrow_up:
src/app-layout/drawer/resizable-drawer.tsx 97.36% <85.71%> (+3.61%) :arrow_up:
src/app-layout/visual-refresh/drawers.tsx 92.70% <90.90%> (-0.32%) :arrow_down:
src/app-layout/utils/use-drawers.ts 98.07% <92.85%> (-1.93%) :arrow_down:
src/app-layout/drawer/index.tsx 95.23% <100.00%> (-3.18%) :arrow_down:
src/app-layout/drawer/overflow-menu.tsx 100.00% <100.00%> (ø)
src/app-layout/index.tsx 94.02% <100.00%> (ø)
src/app-layout/mobile-toolbar/index.tsx 94.44% <100.00%> (+0.32%) :arrow_up:
src/app-layout/visual-refresh/context.tsx 91.72% <100.00%> (+0.05%) :arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 08 '23 20:09 codecov[bot]