components icon indicating copy to clipboard operation
components copied to clipboard

chore: Log warnings for all variants when using deprecated header pro…

Open jperals opened this issue 2 years ago • 1 comments

…p in Expandable section

Description

The header prop is deprecated for all variants, so it makes no sense to log a dev warning only if using the container variant.

Also, renamed ExpandableDefaultHeader to ExpandableDeprecatedHeader, because it's not the header that is rendered when using the default variant —instead, it's the header that is rendered when the deprecated header prop is used with the default, container or footer variant.

Related links, issue #, if available: n/a

How has this been tested?

  • Extended existing unit test for container variant to all other variants
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jperals avatar Jun 07 '23 09:06 jperals

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7ed0c5b) 93.16% compared to head (60070e1) 93.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files         615      615           
  Lines       16323    16323           
  Branches     5340     5340           
=======================================
  Hits        15208    15208           
  Misses       1041     1041           
  Partials       74       74           
Impacted Files Coverage Δ
...c/expandable-section/expandable-section-header.tsx 100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 07 '23 09:06 codecov[bot]