components icon indicating copy to clipboard operation
components copied to clipboard

Date range picker refactoring (embedded)

Open zshakeel-amazon opened this issue 3 years ago • 1 comments

Description

Adds a new variant of the date range picker that is not within a dropdown component. This allows for this variant of the date range picker to be embedded within other dropdown components, avoiding dropdowns within dropdowns.

How has this been tested?

Existing tests. Added additional integration tests for embedded variant. Added demo page.

Documentation changes

No

Related Links

SIM: AWSUI-9912 QUIP: Date-fields-in-Property-Filter-Technical-Design

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • [ ] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • [ ] Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • [ ] Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • [ ] Changes are covered with new/existing unit tests?
  • [ ] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

zshakeel-amazon avatar Aug 03 '22 14:08 zshakeel-amazon

Codecov Report

Merging #116 (ef64cc0) into main (4a7f368) will increase coverage by 0.00%. The diff coverage is 97.36%.

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   92.56%   92.57%           
=======================================
  Files         552      553    +1     
  Lines       15636    15646   +10     
  Branches     4297     4297           
=======================================
+ Hits        14474    14484   +10     
  Misses       1081     1081           
  Partials       81       81           
Impacted Files Coverage Δ
src/date-range-picker/index.tsx 98.05% <ø> (-0.11%) :arrow_down:
src/date-range-picker/use-date-range-picker.tsx 96.55% <96.55%> (ø)
src/date-range-picker/dropdown.tsx 100.00% <100.00%> (+1.13%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 04 '22 13:08 codecov[bot]