terraform-aws-codebuild icon indicating copy to clipboard operation
terraform-aws-codebuild copied to clipboard
verified publisher icon cloudposse

Existing service_role and disabling random_string (if not s3 bucket needed)

Open mgomezzul opened this issue 4 years ago • 3 comments

Existing service_role and disabling random_string (if not s3 bucket needed)

what

  • Adding support to use an existin service_role
  • Disabling random_string creation if no AWS S3 bucket is needed

why

  • Allow the usage of existing IAM roles in new CodeBuild projects
  • Remove unnecessary random_string creation if not needed

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

mgomezzul avatar Oct 12 '21 13:10 mgomezzul

@bradj @brcnblc Hi guys! any comment about the PR? Thanks

mgomezzul avatar Oct 14 '21 12:10 mgomezzul

/test all

nitrocode avatar Nov 17 '21 07:11 nitrocode

This pull request is now in conflict. Could you fix it @mgomezzul? 🙏

mergify[bot] avatar Nov 18 '21 02:11 mergify[bot]