github-commenter icon indicating copy to clipboard operation
github-commenter copied to clipboard

Build amd64 version for Linux

Open Nuru opened this issue 4 years ago • 2 comments

Versions 0.10.0 and 0.10.1 was released with 386 and amd64 versions for Darwin and FreeBSD, but not Linux. Linux amd64 was included in releases v0.9.0 and earlier. Please include Linux amd64 in the releases again.

Nuru avatar Feb 21 '22 04:02 Nuru

Apparently this is some sort of transient error with uploading assets. I was able to get the v0.10.1 assets to upload (renamed originally released assets *-r0 because the workflow would not overwrite them), but after 3 further attempts I have still not been able to get the v0.10.0 assets to upload. I opened a ticket with GitHub support about it. Note this also affected github-status-updater

Nuru avatar Feb 21 '22 05:02 Nuru

I see the linux amd64 release in the latest version

https://github.com/cloudposse/github-commenter/releases/tag/0.14.1

Looking at the other releases, it's bizarre that some releases have 18 assets and some have as few as 3.

https://github.com/cloudposse/github-commenter/releases

It would be good to use .goreleaser file and the same action as atmos to keep the binaries consistent.

https://github.com/cloudposse/atmos/blob/master/.goreleaser.yml

https://github.com/cloudposse/atmos/blob/master/.github/workflows/build.yml#L31

nitrocode avatar Oct 26 '22 02:10 nitrocode