php-buildpack icon indicating copy to clipboard operation
php-buildpack copied to clipboard

Use https instead of git+ssh for podhmo/python-node-semver submodule

Open gmllt opened this issue 1 year ago • 2 comments

Short explanation of the proposed change: Use https instead of git+ssh for podhmo/python-node-semver git submodule as it can cause problems in certain environments where only retrieval of a git repository via https is allowed.

Explanation of the use cases your change solves: Fix git submodul retrieval in environments where git clone is only allowed through https.

  • [x] I have viewed signed and have submitted the Contributor License Agreement

  • [x] I have made this pull request to the develop branch

gmllt avatar Sep 30 '24 05:09 gmllt

This is breaking our automated buildpack packing job as well, please merge this so we can use the new buildpack.

amhuber avatar Oct 05 '24 04:10 amhuber

@amhuber as a workaround, you can force git to use https://github.com/ instead of [email protected]: in git config:

[url "https://github.com/"]
	insteadOf = [email protected]:

gmllt avatar Oct 05 '24 12:10 gmllt

Any news on this? It breaks a couple of our deployments and we currently have to pin them to use 4.6.23.

arthfl avatar Nov 11 '24 13:11 arthfl

I see 4.6.25 is released but still uses ssh method for this submodule. Still breaks our deployments too..Any news on this to change to https?

mohdazaruddin avatar Nov 15 '24 11:11 mohdazaruddin