diego-release icon indicating copy to clipboard operation
diego-release copied to clipboard

Use golang/protobuf instead of gogo/protobuf

Open ebroberson opened this issue 11 months ago • 2 comments

  • [X] Read the Contributing document.

Summary

gogo/protobuf has been deprecated for years. We should be using up-to-date protobufs provided by google.golang.org/protobuf. In order to fit our use cases, a protobuf plugin (protoc-gen-go-bbs) has been created to catch any customizations we want to add.

Submodule Pull Requests (please do these first)

https://github.com/cloudfoundry/auctioneer/pull/20 https://github.com/cloudfoundry/bbs/pull/109 https://github.com/cloudfoundry/cfdot/pull/14 https://github.com/cloudfoundry/executor/pull/116 https://github.com/cloudfoundry/inigo/pull/50 https://github.com/cloudfoundry/locket/pull/27 https://github.com/cloudfoundry/rep/pull/67 https://github.com/cloudfoundry/route-emitter/pull/50 https://github.com/cloudfoundry/routing-api/pull/69 https://github.com/cloudfoundry/routing-info/pull/8 https://github.com/cloudfoundry/vizzini/pull/15

Backward Compatibility

Breaking Change? No

ebroberson avatar Feb 14 '25 20:02 ebroberson

CLA Not Signed

  • :white_check_mark: login: ebroberson / name: Brandon Roberson (1e5cd3f164da1c142ec4b409cc48e4c0b4fa7592, 3778df5e77b4c90e5134eec12ac5536e468f364d, 80bf1e1b9a0ab092f2bd8309ba55128e0f4313ea, a61840290a60e5b3fca47ea0c906fed6a177348f, b332c1616418121354bf8838141d6e0f86162931, 8cff32b2d418fa377731f27b1313bfb39ecb7074, 32ebbf40eeac6444632cf3552db0e7cb9d36214e, 7dd2113887a164a80c03099588096592a5de1b6f, e6ed406f1e9262444408cdcef5de7656c444f493, 256c3c89de660b6559eedad397460c1cb45d0bfa, 54752338ef060d91c26cd7672aeae08d3932fd54, 641f6bd3add6a3ed9d56903b23dc055b7f1652a4, 90ebd5cf326c233869c61f62f4b8a0679ac6bf55, b168545e7d7679c81cf543cd66c130dc8ad33e90, 11a26771ed0bd6e88687b4e3d00d460c324ae507, e18fde7f07d8f05596e848a6dabedf609f11e3c0, bc08dfaa12d1137a8a52df93fa93660e8f495c14, dc6951057e3741594d5ec89b6b1f74d15c32e0fc, a4213d084336db91a9aa3e1ed4e6a5f49c518474, 52de13054e27fb60e5a3bd186102efac50db6ff4, 594f3cbf60559c934765612808eec47f4378e934, 5ebb364a6054af1c2ed453361a4f66c006358848, e7b89e8bec70afe599996b89511402bfd159bf1b, f2623cfb91ba0427aae996fe0fa4cf85490b87a4, 38e66c37aabb5f465fd3c32bbc809662a57bd1e5, c8777800d641d2db60dca03171b50dfa15a5ec30, 805e74f9399ba22cabc4c26aba051d503a4cd5b5, 55615da156c4cb69bbd77af89d62a98695eb877a, 9337ebcde33cc3b18a04dff4febfd66774cee6d4, 7f60b43fba3d52e92f1bc1bc2a76ba67d7670b78, 95599b88b944e06770e39bbbdcbb596c03f533fe, bdf45ce64e98c123f3af6e7bcc9b296a291a16e2, 4668b766e992388b0bcf06edbb9e2660fefa80cb, 510b253bb805f137c5cc8b6b554c90198c2ff9be, c10cefcd0951b9799cc5f8df8816b58e4613b7c1, c177ac31ca823e672cde898d339f3a751679c841, 73cd7a9dc93a280e72c38a1fa06895df7cedfde4, ea5208e41a07cb97b8df1b563ed9d589fc60f2d4, e60bce2da8390132ac4e552886ff3003f952b406)
  • :x: - login: @tas-runtime-bot . The commit (c81946057699b243996b173740af59e1f70c9628, be84a43005f56f046450f77ccc3b9ee0751811db, d9f152ac9f8de44c147078445610c9e261af75af, 0d670d3580eff1e4d7ab45ab90a43f060edc279e, 5ca3aaf1745271550bea3d5b1628b5bdbd0b2351, 52c3f0a5d4414cf242fed8d691db81cdfbcbaf42, c68408ae3fa64e997fe7deb692e55caad86617b5, eede90efb6f3a378b53634b6b58e0d940c502970, a22f16ac54198f162b04ba2c539bbbb5cb447b68, c5453d1db708be05ceb2656e142e70ecee6a8dd7, c684e0180cd61058cca52d43f9a34089bb16d670, f68d4b4a7183adfcb36fc21407b79966ca98e0c0, 8458a791e37982d26cf055c9c017dfe0184a4fba, 11e5dfc38b7ae6bc69642c3f7598532f657440e2, 268faa4e4ddd8696abc287b34d81e8411de0cf1d, 2bf3c12f3320d0ef629501b56509e2057042f305) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

I think this PR needs rebasing off of origin/develop? It seems like stuff it shouldn't need be changing would end up being changed on the develop branch (package definitions, blob info, (re-?)adding a random job property). Otherwise 👍

geofffranks avatar Feb 19 '25 19:02 geofffranks