cli icon indicating copy to clipboard operation
cli copied to clipboard

Support Linux_arm64 binaries

Open rafikt1992 opened this issue 3 years ago • 5 comments

Please provide details on the following items. Failure to do so may result in deletion of your feature request. Developers use the cli on M1 MacBooks via docker. As M1 silicon is ARM64 architecture, Linux_amd64 binaries are needed to run it

What's the user value of this feature request? Devs using the latest MacBook will be able to use cli

Who is the functionality for? Devs using the latest M1 chip macbook or any linux arm machine

How often will this functionality be used by the user? always

Who else is affected by the change? This should not affect the other versions

Is your feature request related to a problem? Please describe. yes, although it does somehow run on amd64 unlike some other binaries, it does echo some binary 64 libs are missing

Describe the solution you'd like since the cli is build in GO. we can adjust the make file to compile for linux_arm64. Hopefully, nothing else is needed

Describe alternatives you've considered no alternatives

Additional context

Note: As of the GA of the v7 CLI, the v6 line is no longer under active development and will be updated only to patch CVEs or fix severe blocking defects with no workarounds.

rafikt1992 avatar Jul 13 '22 09:07 rafikt1992

https://github.com/cloudfoundry/cli/pull/2279

rafikt1992 avatar Jul 13 '22 11:07 rafikt1992

Hey @rafikt1992, I left a comment on #2279, could you provide an example of the current target not working for you?

pivotalgeorge avatar Jul 14 '22 20:07 pivotalgeorge

@rafikt1992, just following up. Could you add repro. steps?

pivotalgeorge avatar Aug 16 '22 17:08 pivotalgeorge

Just a follow up here from a completely different perspective (but directly related to the title): We would like to use ARM binaries to install to debian linux.

The PR https://github.com/cloudfoundry/cli/pull/2279 will allow the binary to be built without adjusting the Makefile on a debian arm docker image. This is because the same docker image should run on both M1 Macs, Intel Macs and Windows.

Reproduceable:

  • Download docker buster image on arm64 platform
  • Install required libs (partly manually, e.g. go)
  • run Make on this repository
    • If the PR is present, the binary can be built (tested only without the lint and test steps)
    • If PR is not present, no binary is built, since the OS is not supported by the Makefile.

This however is still a workaround, since our primary goal is to get a running cf binary within an ARM linux (debian) docker image.

Preferred behavior: If possible, please also provide arm binaries or even better arm installers for (debian) linux, similar to e.g. arm binary for Mac OS X.

PS: If wanted, I can create a new issue for this specific use case. Based on the title and the base requirement of arm binaries, I assumed it would fit in here better than just creating a new issue.

folz-a avatar Sep 22 '22 09:09 folz-a

So it seems like the linux/arm64 binary can be built using the makefile now but is not published anywhere? This would be useful imo, is there blocker for doing that or has no one considered it important enough so far?

fwilhe avatar Jan 31 '23 11:01 fwilhe