cf-java-client icon indicating copy to clipboard operation
cf-java-client copied to clipboard

feat: Add RecentLogs support

Open ZPascal opened this issue 1 year ago • 4 comments

fix: #1181 & #1230

TODO:

  • [ ] Test the change
  • [ ] Add unit tests

ZPascal avatar Aug 01 '24 07:08 ZPascal

Thank you for the PR!

Compilation is currently failing on the implementation missing the new recentLogs method that you added to the client

pivotal-david-osullivan avatar Aug 14 '24 10:08 pivotal-david-osullivan

Thank you @pivotal-david-osullivan & @anthonydahanne for fixing the tests and the reactor part. I am also working on the issue again from the SAP side and I plan to set up a BBL environment to test the change in a CF environment. Let's sync on Slack how we can handle it together and we can discuss the test setup/steps.

ZPascal avatar Nov 01 '24 16:11 ZPascal

Thank you @pivotal-david-osullivan & @anthonydahanne for fixing the tests and the reactor part. I am also working on the issue again from the SAP side and I plan to set up a BBL environment to test the change in a CF environment. Let's sync on Slack how we can handle it together and we can discuss the test setup/steps.

cool! the current struggle is supporting recent , since there does not seem to be a Websocket or SSE endpoint for streaming logs; apparently the CLI polls, so we'd need to do just that.

anthonydahanne avatar Nov 01 '24 23:11 anthonydahanne

CLA Missing ID CLA Not Signed

  • :white_check_mark: login: anthonydahanne / name: Anthony Dahanne (85e6462c2e63d6fe5b572681d4d67fd13cd5b306)
  • :white_check_mark: login: Lokowandtg / name: Georg Lokowandt (a4a87233577102220b1a20cc406f8d3169cb512c)
  • :white_check_mark: login: ZPascal / name: Pascal Zimmermann (9183dfc2cbf9fa3da5f17c38ba642cf2b6d60596, d2c99f0271c920548e8edbd6eb07479ee5a6eeda)
  • :x: The email address for the commit (7a032befb160a233e5591b73d0a6c4f9d22331c6, 03fd4de527122ae374bbc5a52e4a860d20a895c6, af931098c4dc942a05ca56777ac50d40bbcbe010) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.