cf-java-client icon indicating copy to clipboard operation
cf-java-client copied to clipboard

Correctly map metadata

Open JakobFels opened this issue 2 years ago • 2 comments

Fixes #1188

This change will correctly write annotations and labels to a v3 manifest. When using v3 push labels and annotations were not correctly applied/serialized.

This change consists of 2 commits. The second one ensures backward compatibility with existing code setting labels or annotations, as to not require a new major version.

JakobFels avatar Oct 09 '23 09:10 JakobFels

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: jakobfelsatdm (d65b446af360dcdb69a3c402dad468b7b50b1211, a6b03ddc0fc7074855fb1d9c4cb343d37eb227a7)

@JakobFels thank you for the contribution! We are working through PRs at the moment.

Could you please add integration test support to cover the new feature?

As an example, annotations checks can be seen in the integration-test module in places such as here

anthonydahanne avatar Feb 15 '24 14:02 anthonydahanne