cloudfoundry
Reorganize credhub tests so that test setup is not run when tests are skipped
What is this change about?
Because 'AssistedCredhubDescribe' and 'NonAssistedCredhubDescribe' were nested under the top-level 'CredhubDescribe', the BeforeEach of the top-level describe block would be run even when Assisted or NonAssisted tests were skipped. This removes the top-level CredhubDescribe and uses helper functions for the set up functionality shared by the two types of tests.
What version of cf-deployment have you run this cf-acceptance-test change against?
v21.8.0
Please check all that apply for this PR:
- [ ] introduces a new test --- Are you sure everyone should be running this test?
- [x] changes an existing test
- [ ] requires an update to a CATs integration-config
Did you update the README as appropriate for this change?
- [ ] YES
- [x] N/A
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
This test saves as much as 3 minutes and 20 seconds from the test suite. The unnecessary test setup takes about 100 seconds, so in cases where all credhub tests are skipped, this saves about 200 seconds or 3 minutes and 20 seconds.
What is the level of urgency for publishing this change?
- [ ] Urgent - unblocks current or future work
- [x] Slightly Less than Urgent
Tag your pair, your PM, and/or team!
@dsabeti it seems like #612 includes the changes in this PR. Can I close this PR?
