cloudfoundry
Print AppReport after dynamic ASG test for better debugging
What is this change about?
This change adds an app report to the end of the dynamic ASG tests. If something goes wrong with the app, it's not currently possible to know why.
What version of cf-deployment have you run this cf-acceptance-test change against?
v21.8.0
Please check all that apply for this PR:
- [ ] introduces a new test --- Are you sure everyone should be running this test?
- [x] changes an existing test
- [ ] requires an update to a CATs integration-config
Did you update the README as appropriate for this change?
- [ ] YES
- [x] N/A
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
This change adds a single call to cf logs --recent, so at most a few seconds.
What is the level of urgency for publishing this change?
- [ ] Urgent - unblocks current or future work
- [x] Slightly Less than Urgent
Tag your pair, your PM, and/or team!
@dsabeti the CredhubDescribe function includes a similar BeforeEach to AssistedCredhubDescribe and NonAssistedCredhubDescribe that should skip any setup if neither "assisted" nor "non-assisted" are set.
Also, credhub/service_keys.go uses a similar pattern to credhub/service_bindings.go, so if we one is changed then I think the other should be changed as well.
If you think https://github.com/cloudfoundry/cf-acceptance-tests/pull/612/commits/d1e1265ab33a4c7f63f7497907bff813cf9de053 is worth it, could you please also apply similar changes to credhub/service_keys.go. Alternatively, if you remove https://github.com/cloudfoundry/cf-acceptance-tests/pull/612/commits/d1e1265ab33a4c7f63f7497907bff813cf9de053 from this PR, then I'm happy to merge it.
